fix(sacred-valley): review polish — render-gen guard, auth-boundary tests, PNG sig, dedup note

Addresses final-review findings: I1 render-generation guard prevents a double-mount
/timer leak on rapid re-navigation; I2 adds anonymous-rejection tests for the owner-only
POST /speedtest/run and /health/check; M1 CSS comment; M2 cron↔worker dedup note;
M4 full 8-byte PNG signature check; M5 card-contract unit test for all 7 cards.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
root
2026-06-02 23:20:14 +10:00
parent 1eadd41990
commit b82b90d2f5
7 changed files with 47 additions and 2 deletions

View File

@@ -175,7 +175,7 @@ ul.plain li:last-child { border-bottom: none; }
--hue-dross: #ff4f2e; --hue-yerin: #c45a4a; --hue-orthos: #6fa86a; */
}
#sv-cards { display: grid; grid-template-columns: repeat(6, 1fr); gap: 16px; align-items: start; }
.sv-card { grid-column: span 2; } /* m default */
.sv-card { grid-column: span 2; } /* s / fallback (factory always sets data-size) */
.sv-card[data-size="s"] { grid-column: span 2; }
.sv-card[data-size="m"] { grid-column: span 3; }
.sv-card[data-size="l"] { grid-column: span 6; }

View File

@@ -14,8 +14,10 @@ import speedtest from './cards/speedtest.js';
const CARD_MODULES = [clock, weather, hostPerf, jobs, inbox, search, speedtest]; // grows in later tasks
let active = []; // mounted cards needing stop()
let renderGen = 0; // guards against overlapping async renders
export async function render(main) {
const myGen = ++renderGen;
active.forEach(c => c.stop && c.stop()); active = []; stopHealthBand();
mount(main,
el('h1', { class: 'view-h1' }, 'Sacred Valley'),
@@ -26,6 +28,9 @@ export async function render(main) {
let layout = { card_order: [], hidden: [], sizes: {} };
try { layout = await api.get('/api/dashboard/layout'); } catch { /* defaults */ }
// A newer render() started while we awaited — bail before mounting timers/DOM
// so we don't double-mount cards or leak intervals onto the live grid.
if (myGen !== renderGen) return;
const grid = document.getElementById('sv-cards');
const ordered = orderCards(CARD_MODULES, layout);