Hynes/Void-Homelab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(health): expose external in /services payload and accept on add/edit

Browse Source 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
root
2026-06-08 00:55:19 +10:00
parent 789dc2442e
commit d7a1a47b28
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/api/routes/health.js
View File

@@ -17,7 +17,7 @@ router.get('/services', asyncWrap(async (_req, res) => {
const list = g.services.map(s => {
const st = statuses[s.id];
return {
id: s.id, name: s.name, host: s.host, url: s.url, icon: iconSlug(s),
id: s.id, name: s.name, host: s.host, url: s.url, external: s.external ?? null, icon: iconSlug(s),
status: st?.status || 'unknown', latency_ms: st?.latency_ms ?? null,
detail: st?.detail || null, checked_at: st?.checked_at || null
};
@@ -39,6 +39,7 @@ const svcBody = z.object({
category: z.enum(['agents', 'infrastructure', 'media', 'other']).default('other'),
host: z.string().max(120).optional(),
url: z.string().url(),
external: z.string().url().optional(),
icon: z.string().max(64).optional(),
check: checkCfg.optional()
});

12
tests/api/health.test.js
View File

@@ -28,6 +28,18 @@ describe('health api (DB-backed registry)', () => {
expect(infra.services.find(s => s.id === 'gitea').status).toBe('ok');
});
it('GET /services includes external on every tile; POST round-trips it', async () => {
const res = await request(app).get('/api/health/services').set(ownerHeaders);
const all = res.body.flatMap(g => g.services);
expect(all.every(s => 'external' in s)).toBe(true); // key present (may be null)
expect(all.find(s => s.id === 'gitea').external).toBeNull(); // no domain set
await request(app).post('/api/health/services').set(ownerHeaders)
.send({ id: 'gramps', name: 'Gramps', category: 'infrastructure', url: 'http://192.168.1.99', external: 'https://gramps.hynesy.com' });
const res2 = await request(app).get('/api/health/services').set(ownerHeaders);
const gramps = res2.body.flatMap(g => g.services).find(s => s.id === 'gramps');
expect(gramps.external).toBe('https://gramps.hynesy.com');
});
it('POST /services adds a service that shows up in the band', async () => {
const create = await request(app).post('/api/health/services').set(ownerHeaders)
.send({ id: 'ollama', name: 'Ollama', category: 'agents', host: 'ct102', url: 'http://192.168.1.185:11434' });